Re: PR/44847 CVS commit: src/sys/sys

[christos%zoulas.com@localhost (Christos Zoulas)]

On Mar 18,  2:30pm, martin%duskware.de@localhost (Martin Husemann) wrote:
-- Subject: Re: PR/44847 CVS commit: src/sys/sys

| The following reply was made to PR standards/44847; it has been noted by 
GNATS.
| 
| From: Martin Husemann <martin%duskware.de@localhost>
| To: gnats-bugs%NetBSD.org@localhost
| Cc: 
| Subject: Re: PR/44847 CVS commit: src/sys/sys
| Date: Sun, 18 Mar 2012 15:28:08 +0100
| 
|  On Sun, Mar 18, 2012 at 02:25:02PM +0000, Christos Zoulas wrote:
|  >  You realize that the internal kernel blocksize bookkeeping was already
|  >  signed (va_blocksize)?
|  
|  No, can we fix that instead? ;-)

That's a larger undertaking :-)

|  >  Don't know, but if you grep all 360+ usages of st_blksize in userland,
|  >  they all assumed signed (except 1, in bin/cat).
|  
|  Gross - for what value of "assumed" is that?

Checking if negative or 0, casting to signed etc.

christos