NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: install/45816: Screen corruption in German sysinst install

The following reply was made to PR install/45816; it has been noted by GNATS.

From: Julian Djamil Fagir <>
Subject: Re: install/45816: Screen corruption in German sysinst install
Date: Wed, 29 Feb 2012 03:16:54 +0100

 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 >  I just did an English-language installation using the same media, and
 >  saw similar screen corruption as in the German-language install.  The
 >  initial stray close parenthesis doesn't appear, but if you keep
 >  pressing enter where prompted for the CD drive as described in the
 >  original PR, additional copies of the text from the top of the screen
 >  appear just as they did in the German-language install.
 the problem is a msg_display_add instead of msg_display, and a reoccurring
 call to that menu.
 With the attached patches, the user will see a single window with the error
 message instead of the error text appearing above the text about entering the
 CD path etc. Imho, this is better anyway (the user will really see the error
 instead of just somewhere inside the text appearing).
 I hope the diff format is right. If not, it's only about four lines all in
 all, you can apply it by hand as well.
 And I just hope my mailer now gets the encoding right.
 Regards, Julian
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=menus.mi.diff
 --- menus.mi
 +++ menus.mi
 @@ -321,11 +321,11 @@
                        clean_xfer_dir ? MSG_Yes : MSG_No);},
                action {process_menu(MENU_yesno, deconst(MSG_delete_xfer_file));
                        clean_xfer_dir = yesno; };
  menu cdromsource, y=-4, x=0, w=70, no box, no clear, exitstring MSG_Continue;
 -      display action { msg_display_add(MSG_cdromsource); };
 +      display action { msg_display(MSG_cdromsource); };
        option {src_legend(menu, MSG_Device, cdrom_dev);},
                action { src_prompt(MSG_dev, cdrom_dev, sizeof cdrom_dev); };
        option {src_legend(menu, MSG_Set_dir_bin, set_dir_bin);},
                action { src_prompt(MSG_Set_dir_bin, set_dir_bin, sizeof 
set_dir_bin); };
        option {src_legend(menu, MSG_Set_dir_src, set_dir_src);},
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=util.c.diff
 --- util.c
 +++ util.c
 @@ -571,11 +571,11 @@
        if (silent)
        else {
 -              msg_display_add("\r\n\r\n");
 +              process_menu(MENU_ok, NULL);
        /* ask for paths on the CD */
        process_menu(MENU_cdromsource, NULL);

Home | Main Index | Thread Index | Old Index