[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/45889: sdtemp(4) driver does strange stuff when loaded as module
The following reply was made to PR kern/45889; it has been noted by GNATS.
From: Paul Goyette <paul%whooppee.com@localhost>
Subject: Re: kern/45889: sdtemp(4) driver does strange stuff when loaded as
Date: Tue, 14 Feb 2012 07:24:15 -0800 (PST)
Module Name: src
Committed By: pgoyette
Date: Tue Feb 14 15:08:07 UTC 2012
src/sys/dev/pci: amdpm_smbus.c amdpmvar.h ichsmb.c nfsmb.c
Replace the xxx_acquire()/xxx_release() rwlocks with mutexes. There are
only RW_WRITERs for these, and no RW_READERs, so no need to incur the
extra overhead of allowing for both. As discussed on tech-kern.
For piixpm and ichsmb, the acquire/release protocol needs to be used,
even if the request is I2C_F_POLL'd (or if the device supports only
polled mode). Otherwise multiple requests can be running at the same
time, and they stomp on each other and create anomolous results.
Part 2 addresses my PR kern/45889
3 ACKs from releng
Main Index |
Thread Index |