bin/45542: Misplaced parenthesis in rshd.c

[henning.petersen%t-online.de@localhost]

>Number:         45542
>Category:       bin
>Synopsis:       Misplaced parenthesis in rshd.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 30 09:25:00 +0000 2011
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Misplaced parenthesis in rshd.c
>How-To-Repeat:

>Fix:
diff -u -p -r1.48 rshd.c
--- libexec/rshd/rshd.c 27 Aug 2011 17:46:34 -0000      1.48
+++ libexec/rshd/rshd.c 30 Oct 2011 07:39:38 -0000
@@ -457,7 +457,7 @@ doit(struct sockaddr *fromp)
        }
 
        if ((pam_err = pam_set_item(pamh, PAM_RUSER, remuser)) != PAM_SUCCESS ||
-           (pam_err = pam_set_item(pamh, PAM_RHOST, hostname) != PAM_SUCCESS)){
+           (pam_err = pam_set_item(pamh, PAM_RHOST, hostname)) != PAM_SUCCESS){
                syslog(LOG_ERR|LOG_AUTH, "pam_set_item(): %s",
                    pam_strerror(pamh, pam_err));
                rshd_errx(EXIT_FAILURE, incorrect);