Re: PR/45269 CVS commit: src/bin/sh

[David Laight <david%l8s.co.uk@localhost>]

The following reply was made to PR bin/45269; it has been noted by GNATS.

From: David Laight <david%l8s.co.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/45269 CVS commit: src/bin/sh
Date: Tue, 23 Aug 2011 14:16:41 +0100

 On Tue, Aug 23, 2011 at 11:50:04AM +0000, Christos Zoulas wrote:
 > The following reply was made to PR bin/45269; it has been noted by GNATS.
 > 
 > From: christos%zoulas.com@localhost (Christos Zoulas)
 > To: Andreas Gustafsson <gson%gson.org@localhost>, 
 > gnats-bugs%NetBSD.org@localhost
 > Cc: gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
 > Subject: Re: PR/45269 CVS commit: src/bin/sh
 > Date: Tue, 23 Aug 2011 07:45:27 -0400
 > 
 >  On Aug 23,  1:52pm, gson%gson.org@localhost (Andreas Gustafsson) wrote:
 >  -- Subject: Re: PR/45269 CVS commit: src/bin/sh
 >  
 >  | Christos Zoulas wrote:
 >  | >  PR/45269: Andreas Gustafsson: Instead of falling off the edge when 
 > eating trailing newlines
 >  | >  if the block has moved, arrange so that trailing newlines are never 
 > placed in the string
 >  | >  in the first place, by accumulating them and adding them only after 
 > we've encountered a
 >  | >  non-newline character. This allows also for more efficient appending 
 > since we know how much
 >  | >  we need beforehand. From FreeBSD.
 >  | 
 >  | Excellent, thank you!  Will you be submitting a pullup request to releng?
 >  
 >  Thanks for the reproducable bug report. Without it, it would be impossible 
 > to
 >  find! Yes, I've issued a pullup request to -5 already.
 
 Either I'm going blind or something else is wrong.
 I don't believe the netbsd code in rev 1.84 is wrong.
 The code prior to rev 1.68 was wrong, the fix from freebsd
 might have been removing the old version of that code.
 
        David
 
 -- 
 David Laight: david%l8s.co.uk@localhost