Re: kern/44986: "screens" gets stuck during detach

[Matthias Scheler <tron%zhadum.org.uk@localhost>]

The following reply was made to PR kern/44986; it has been noted by GNATS.

From: Matthias Scheler <tron%zhadum.org.uk@localhost>
To: NetBSD GNATS <gnats-bugs%NetBSD.org@localhost>
Cc: Christos Zoulas <christos%zoulas.com@localhost>
Subject: Re: kern/44986: "screens" gets stuck during detach
Date: Wed, 25 May 2011 22:25:37 +0100

 On Wed, May 25, 2011 at 08:45:02PM +0000, Matthias Scheler wrote:
 >  On Tue, May 24, 2011 at 11:37:47AM -0400, Christos Zoulas wrote:
 >  > On May 24,  2:17pm, tron%zhadum.org.uk@localhost (Matthias Scheler) wrote:
 >  > -- Subject: Re: kern/44986: "screens" gets stuck during detach
 >  > 
 >  > | On Tue, May 24, 2011 at 08:42:11AM -0400, Christos Zoulas wrote:
 >  > | > Backout the select changes and leave the sigsuspend changes. If that 
 > fixes
 >  > | > the problem, then the problem is with select. I don't see how putting 
 > the
 >  > | > code in a separate function in sys_sig.c makes a difference.
 >  > | 
 >  > | I'm wondering how the signal mask gets restored in case of select(2) 
 > now.
 >  > | There used to be code which did that. But the old signal mask is simply
 >  > | copied into a property of the "lwp" structure.
 >  > 
 >  > The same way that it is restored for sigsuspend. Look in kern_sig.c
 >  
 >  I've reverted "sys/kern/sys_select.c" to revision 1.30 in my source tree
 >  and can no longer reproduce the problem.
 
 Reverting to revision 1.31 does *not* fix the problem.
 
        Kind regards
 
 -- 
 Matthias Scheler                                  http://zhadum.org.uk/