Re: toolchain/44844: [dM] make(1) expands variables inconsistently

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR toolchain/44844; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: toolchain/44844: [dM] make(1) expands variables inconsistently
Date: Sun, 1 May 2011 04:39:02 +0000

 On Fri, Apr 08, 2011 at 06:45:00PM +0000, der Mouse wrote:
  >     This could, I suppose, be deliberate, but it is not documented
  >     as far as I can see, and GNU make (after removing the .PHONYs,
  >     which it doesn't support) does behave the same for the foo and
  >     bar cases, so I am inclined to believe the NetBSD behaviour is
  >     a bug.
 
 It is, and as I'm pretty sure I've already stated somewhere I can't
 currently find (maybe it was on tech-toolchain?) this was fixed before
 branching -5.
 
  >     Relative to parse.c,v 1.120.2.3:
  > 
  >     --- a/usr.bin/make/parse.c
  >     +++ b/usr.bin/make/parse.c
  >     @@ -1573,7 +1573,7 @@ Parse_DoVar(char *line, GNode *ctxt)
  >             if (!Var_Exists(line, ctxt))
  >                 Var_Set(line, "", ctxt, 0);
  >      
  >     -       cp = Var_Subst(NULL, cp, ctxt, FALSE);
  >     +       cp = Var_Subst(NULL, cp, VAR_CMD, FALSE);
  >             oldVars = oldOldVars;
  >             freeCp = TRUE;
  >      
 
 This, however, is not the fix in -5, so I want to spend some time to
 chew this over before committing to it.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost