[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/36865 (opencrypto - deflate wastes time with useless data copying)
Synopsis: opencrypto - deflate wastes time with useless data copying
State-Changed-When: Mon, 21 Feb 2011 21:53:51 +0000
Submitter is satisfied. I'll care about the GZIP sync later.
About the memcpy(,,0): While it doesn't look nice, it is
OK for memcpy() itself. As I understand it, this case can
only occur if either a compressed buffer without proper
termination is handled (as produced by former versions of
this code), or the zlib bug described in PR kern/44594 is
hit. Both problems should be fixed eventually, and then the
extra check for 0 length shouls never hit.
Main Index |
Thread Index |