NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-i386/44563: boot loader prompt doesn't read keyboard input on a MacBook1,1



The following reply was made to PR port-i386/44563; it has been noted by GNATS.

From: Taylor R Campbell <campbell+netbsd%mumble.net@localhost>
To: Jared McNeill <jmcneill%invisible.ca@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, port-i386-maintainer%netbsd.org@localhost,
        gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: port-i386/44563: boot loader prompt doesn't read keyboard input
        on a MacBook1,1
Date: Mon, 14 Feb 2011 23:16:54 +0000

    Date: Mon, 14 Feb 2011 17:41:22 -0500 (EST)
    From: Jared McNeill <jmcneill%invisible.ca@localhost>
 
    I'd rather get rid of the wait() calls, if that still works for you I'll 
    check in a modified patch.
 
 I just confirmed that the following patch works.  I used wait because
 I wanted to avoid busy-waiting, but I see now that wait itself just
 busy-waits anyway.
 
 Index: pcio.c
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/i386/stand/lib/pcio.c,v
 retrieving revision 1.23.8.2
 diff -p -u -r1.23.8.2 pcio.c
 --- pcio.c     28 Nov 2009 15:40:47 -0000      1.23.8.2
 +++ pcio.c     14 Feb 2011 23:16:12 -0000
 @@ -265,6 +265,8 @@ getchar(void)
        default: /* to make gcc -Wall happy... */
        case CONSDEV_PC:
  #endif
 +              while (!coniskey())
 +                      continue;
                c = congetc();
  #ifdef CONSOLE_KEYMAP
                {
 


Home | Main Index | Thread Index | Old Index