Re: PR/44529 CVS commit: src/sbin/fsck_msdos

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR bin/44529; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: David Holland <dholland-bugs%netbsd.org@localhost>, 
gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/44529 CVS commit: src/sbin/fsck_msdos
Date: Wed, 9 Feb 2011 18:59:39 -0500

 On Feb 9,  5:17am, dholland-bugs%netbsd.org@localhost (David Holland) wrote:
 -- Subject: Re: PR/44529 CVS commit: src/sbin/fsck_msdos
 
 | On Mon, Feb 07, 2011 at 05:40:05PM +0000, Christos Zoulas wrote:
 |  >  Log Message:
 |  >  PR/44529: Martin Danielsson: fsck_msdos crashes when verifying corrupt 
file
 |  >  system. Avoid using the long name index when it is 0. Refactor the code 
to
 |  >  avoid duplication.
 | 
 | I assume you were intending for this for pullup? It applies cleanly to
 | both -5 and -4, but I'm somewhat hesitant as it's not all that small,
 | I have no easy ability to test it, and I doubt releng does either...
 
 The original patch was more complicated and slightly wrong. I am too
 reluctant to pullup because of the lack of testing. I don't think it
 is critical to patch because it only affects direntries that have a zero
 byte in the longname where they are not supposed to.
 
 christos