NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/44235: lint1 fails when compiling mesa for sparc

The following reply was made to PR bin/44235; it has been noted by GNATS.

From: "Valeriy E. Ushakov" <>
Subject: Re: bin/44235: lint1 fails when compiling mesa for sparc
Date: Mon, 17 Jan 2011 05:00:25 +0300

 xgetblk doesn't check if the next free block it pick up has enough
 space for the allocation.  We come asking for s=41104 bytes, there
 isn't enough space in the current block, so we get one from freelist
 and don't check that it has enough space, so in
 216             mb->nfree -= s;
 size_t nfree gets wrapped into 0xffff.... values and after that all
 bets are off, since this block now has enough memory for everything :)
 jmc@ tried to fix this:
   revision 1.8
   date: 2002/06/28 05:03:55;  author: jmc;  state: Exp;  lines: +9 -2
   Change xgetblk to detect cases where the requested size is more than mblklen.
   (generally it's 20k). Adjust mblklen temporarily to the size of the block
   required and allocate one. This avoids coredumps when mapping in identifiers
   that have huge values. (In my example it was a char[] for a 640k pixmap).
 but didn't address the case of frmblks != NULL.

Home | Main Index | Thread Index | Old Index