Re: kern/44144 (ifconfig causes assertion failure in vfs_lookup.c)

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/44144; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/44144 (ifconfig causes assertion failure in vfs_lookup.c)
Date: Sun, 26 Dec 2010 22:16:04 +0000

 On Sun, Dec 26, 2010 at 08:45:02PM +0000, Alan Barrett wrote:
  >  >  Yeah, but that will take some restructuring; as things are it's going
  >  >  to attempt wpi_cache_firmware every time it goes through wpi_init
  >  >  until it succeeds, and each successive call is going to print a
  >  >  message.
  >  
  >  I guess I expected the first failure to cause an error to be returned to
  >  userland.  If I run "ifconfig wpi0 up" again, then it would be fine if
  >  it printed another error message, but preferably only one each time.
 
 Several of the internalcalls to wpi_init aren't checked for failure.
 If you added those checks it might do what you want; it might also go
 kablooey... I'm not overly familiar with network drivers in general
 (let alone this one in particular) and I don't have a wpi myself, so I
 don't really want to try tinkering blindly.
 
  >  >  This patch should cover more of the bases. (But note that I don't have
  >  >  one of these, so I haven't tested it at all...)
  >  
  >  Thank you; I'll try it tomorrow.
 
 Let me know when/if I should commit...
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost