port-powerpc/43911: plb_attach for PowerPC 4xx hangs checking local PLB devices against PVR

[clarkjc%runbox.com@localhost]

>Number:         43911
>Category:       port-powerpc
>Synopsis:       plb_attach for PowerPC 4xx hangs checking local PLB devices 
>against PVR
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    port-powerpc-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 27 06:35:00 +0000 2010
>Originator:     John Clark
>Release:        NetBSD-current
>Organization:
>Environment:
Can't run uname yet...
>Description:
plb_attach in src/sys/arch/powerpc/ibm4xx/dev/plb.c hangs checking local PLB 
devices against the processor version retrieved from the PVR register.  It 
looks like a copy/paste error: plb_dev[i] was used instead of local_plb_devs.  
The problem was introduced in version 1.15 of 
src/sys/arch/powerpc/ibm4xx/dev/plb.c on Thu Mar 18 13:47:04 2010 UTC.
>How-To-Repeat:
Try to boot kernel on PPC4xx CPU when your configuration has local PLB devices.
>Fix:
Index: plb.c
===================================================================
RCS file: /cvsroot/src/sys/arch/powerpc/ibm4xx/dev/plb.c,v
retrieving revision 1.15
diff -u -r1.15 plb.c
--- plb.c       18 Mar 2010 13:47:04 -0000      1.15
+++ plb.c       27 Sep 2010 06:16:36 -0000
@@ -179,7 +179,7 @@
        }
 
        while (local_plb_devs && local_plb_devs->plb_name != NULL) {
-               if (plb_devs[i].plb_pvr != pvr)
+               if (local_plb_devs->plb_pvr != pvr)
                        continue;
 
                paa.plb_name = local_plb_devs->plb_name;