[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/43355 CVS commit: src/usr.bin/seq
The following reply was made to PR bin/43355; it has been noted by GNATS.
From: "David A. Holland" <dholland%netbsd.org@localhost>
Subject: PR/43355 CVS commit: src/usr.bin/seq
Date: Thu, 27 May 2010 08:40:20 +0000
Module Name: src
Committed By: dholland
Date: Thu May 27 08:40:20 UTC 2010
Rerun valid_format() both before and after unescaping the format
string, in case the format string contains printf conversions
assembled from escape sequences.
A better approach might be to adjust the unescape logic to avoid
generating printf conversions (e.g. convert \x25 to %% instead of %)
but that's somewhat problematic and it's not really worth taking the
Running valid_format() only after unescaping would also be somewhat
tidier but makes printing the invalid format string problematic,
because the unescape logic runs in place.
None of these cases are really worth worrying about in detail, but now
at least they don't result in SIGSEGV.
Related to PR 43355.
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/usr.bin/seq/seq.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |