kern/43257: default SCSI-tape timeing parameters not selectable by kernel config

[Wolfgang.Stukenbrock%nagler-company.com@localhost]

>Number:         43257
>Category:       kern
>Synopsis:       default SCSI-tape timeing parameters not selectable by kernel 
>config
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed May 05 12:00:01 +0000 2010
>Originator:     W. Stukenbrock
>Release:        NetBSD 5.0.2
>Organization:
Dr. Nagler & Company GmbH
        
>Environment:
        
        
System: NetBSD s012 4.0 NetBSD 4.0 (NSW-S012) #11: Fri Mar 26 15:01:49 CET 2010 
root@s012:/usr/src/sys/arch/amd64/compile/NSW-S012 amd64
Architecture: x86_64
Machine: amd64
>Description:
        The timeing parameter ST_IO_TIME, ST_CTL_TIME and ST_SPC_TIME are 
defined in /usr/src/sys/dev/scsipi/stvar.h
        and cannot be changed by kernel config.
        For some Tape devices the defined values are too small, so timeouts 
happens in non-error situations.
>How-To-Repeat:
        not relevant
>Fix:
        The following patch will make ST_IO_TIME, ST_CTL_TIME and ST_SPC_TIME 
configurable in the
        kernel config. The previous values are kept as default.
        The files /usr/src/sys/dev/scsipi/stvar.h and 
/usr/src/sys/dev/scsipi/files.scsipi are affected.

--- stvar.h     2010/05/05 11:45:52     1.1
+++ stvar.h     2010/05/05 11:49:02
@@ -57,9 +57,18 @@
 #include <dev/scsipi/scsipi_all.h>
 #include <dev/scsipi/scsiconf.h>
 
+#include "opt_scsi.h"
+
+/* default values for timeout paramters - may be overwritten in kernel config 
*/
+#ifndef ST_IO_TIME
 #define        ST_IO_TIME      (3 * 60 * 1000)         /* 3 minutes */
+#endif
+#ifndef ST_CTL_TIME
 #define        ST_CTL_TIME     (30 * 1000)             /* 30 seconds */
+#endif
+#ifndef ST_SPC_TIME
 #define        ST_SPC_TIME     (4 * 60 * 60 * 1000)    /* 4 hours */
+#endif
 
 #define        ST_RETRIES      4       /* only on non IO commands */
 

--- files.scsipi        2010/05/05 11:45:52     1.1
+++ files.scsipi        2010/05/05 11:46:26
@@ -7,6 +7,7 @@
 defflag        opt_scsi.h              SCSIVERBOSE ST_ENABLE_EARLYWARN
                                SES_ENABLE_PASSTHROUGH SCSI_OLD_NOINQUIRY
 defparam opt_scsi.h            ST_MOUNT_DELAY SDRETRIES SD_IO_TIMEOUT
+                               ST_IO_TIME ST_CTL_TIME ST_SPC_TIME
 
 defflag        opt_scsipi_debug.h      SCSIPI_DEBUG
 defparam opt_scsipi_debug.h    SCSIPI_DEBUG_TYPE

>Unformatted: