[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/43192 CVS commit: src/games/factor
The following reply was made to PR misc/43192; it has been noted by GNATS.
From: Matthias Drochner <drochner%netbsd.org@localhost>
Subject: PR/43192 CVS commit: src/games/factor
Date: Tue, 27 Apr 2010 18:11:19 +0000
Module Name: src
Committed By: drochner
Date: Tue Apr 27 18:11:19 UTC 2010
-Fix an old bug in the "pollard" code: it gets its argument passed
by reference, and changes the value behind the pointer under some
circumstances (basically if it finds more than 2 different factors).
It also calls itself if it finds a factor which is not considered prime
(by openssl's miller-rabin check) and uses the call argument afterwards.
This doesn't work -- we need to copy the argument into its own storage.
-Modify the code to do the "rho" algorithm as was initially announced.
It takes somewhat longer in rare cases, but still works in cases where
the "p-1" algorithm is unusable. This might fix PR misc/43192
by Luiz Henrique de Figueiredo.
-Add some optional debug support, minor cleanup.
To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/games/factor/factor.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |