port-powerpc/43022: assembling powerpc64 atomic_add.S fails while building librump

[dennis.c.ferguson%gmail.com@localhost]

>Number:         43022
>Category:       port-powerpc
>Synopsis:       assembling powerpc64 atomic_add.S fails while building librump
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    port-powerpc-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 20 11:35:00 +0000 2010
>Originator:     Dennis Ferguson
>Release:        very recent 5.99.24
>Organization:
>Environment:
NetBSD acer.hk.akit-ferguson.com 5.99.24 NetBSD 5.99.24 (GENERIC) #0: Sun Mar 
14 17:25:30 HKT 2010  
dennis%acer.hk.akit-ferguson.com@localhost:/usr/obj/sys/arch/amd64/compile/GENERIC
 amd64

>Description:
Doing a macppc64 build fails with the following when assembling
common/lib/libc/arch/powerpc64/atomic_add.S:

#   compile  librump/atomic_add.o
/usr/src/obj/tooldir.NetBSD-5.99.24-amd64/bin/powerpc64--netbsd-gcc  -D_LOCORE 
-Wa,-fatal-warnings   -I/usr/src/lib/librump/../../sys/rump/include  
-D_RUMPKERNEL -D_KERNEL -DMULTIPROCESSOR -D_MODULE -DMODULAR -DMAXUSERS=32 
-DDIAGNOSTIC -DCOMPAT_50 -DDEBUGPRINT -I/usr/src/lib/librump -I. 
-I/usr/src/lib/librump/../../sys/rump/../../common/include 
-I/usr/src/lib/librump/../../sys/rump/../arch 
-I/usr/src/lib/librump/../../sys/rump/include 
-I/usr/src/lib/librump/../../sys/rump/librump/rumpkern/opt -nostdinc 
-I/usr/src/lib/librump/../../sys/rump/.. -D__NetBSD__ 
-I/usr/src/lib/librump/../../sys/rump/librump/rumpkern 
-I/usr/src/lib/librump/../../sys/rump/librump/rumpvfs 
-I/usr/src/lib/librump/../../sys/rump/librump/rumpnet 
-I/usr/src/lib/librump/../../sys/rump/librump/rumpdev 
-I/usr/src/lib/librump/../../sys/rump/../lib/libkern/arch/   
-I/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/quad
 -I/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../commo
 n/lib/libc/string 
-I/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/powerpc64/string
 -I/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/include  
-c -traditional-cpp    
/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/powerpc64/atomic/atomic_add.S
 -o atomic_add.o
/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/powerpc64/atomic/../../powerpc/atomic/atomic_add.S:
 Assembler messages:
/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/powerpc64/atomic/../../powerpc/atomic/atomic_add.S:37:
 Error: bad expression
/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/powerpc64/atomic/../../powerpc/atomic/atomic_add.S:37:
 Error: syntax error; found `1' but expected `,'
/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/powerpc64/atomic/../../powerpc/atomic/atomic_add.S:37:
 Error: junk at end of line: `10,0,%3'

>How-To-Repeat:
Do a

    MACHINE=macppc64 ./build.sh distribution
>Fix:
The following patch fixes the problem.  The same change was
made to the powerpc version of the file, but powerpc64 was
overlooked:

Index: atomic_op_asm.h
===================================================================
RCS file: /cvsroot/src/common/lib/libc/arch/powerpc64/atomic/atomic_op_asm.h,v
retrieving revision 1.3
diff -u -r1.3 atomic_op_asm.h
--- atomic_op_asm.h     28 Apr 2008 20:22:52 -0000      1.3
+++ atomic_op_asm.h     20 Mar 2010 09:54:20 -0000
@@ -32,6 +32,7 @@
 #ifndef _ATOMIC_OP_ASM_H_
 #define        _ATOMIC_OP_ASM_H_
 
+#define _NOREGNAMES
 #include <machine/asm.h>
 
 #if defined(_KERNEL)