Re: bin/42363 (racoon uses a wrong IPsec-SA that is for different peer)

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR bin/42363; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/42363 (racoon uses a wrong IPsec-SA that is for different
        peer)
Date: Sat, 6 Mar 2010 19:31:51 +0000

 (not sent to gnats)
 
    ------
 
 From: YASUOKA Masahiko <yasuoka%iij.ad.jp@localhost>
 To: christos%NetBSD.org@localhost
 Cc: gnats-admin%netbsd.org@localhost
 Subject: Re: bin/42363 (racoon uses a wrong IPsec-SA that is for different
        peer)
 Date: Sat, 06 Mar 2010 03:17:22 +0900 (JST)
 
 The patch attached on bin/42363 was wrong.
 
 struct ph2handle has following 2 list entries:
 
   chain    - to iterate all ph2handle
   ph1bind  - to iterate ph2handle that are bound by given ph1handle.
 
 'ph1bind' should be used for getph2bymsgid() because the fucntion is
 to search a ph2handle that belongs with the given ph1handle and has
 the same msgid as the given msgid.
 
 Please apply following patch:
 
 Index: handler.c
 ===================================================================
 RCS file: /cvsroot/NetBSD/src/crypto/dist/ipsec-tools/src/racoon/handler.c,v
 retrieving revision 1.31
 diff -u -p -r1.31 handler.c
 --- handler.c   22 Nov 2009 19:34:55 -0000      1.31
 +++ handler.c   5 Mar 2010 18:04:26 -0000
 @@ -573,7 +573,7 @@ getph2bymsgid(iph1, msgid)
  {
         struct ph2handle *p;
  
 -       LIST_FOREACH(p, &iph1->ph2tree, chain) {
 +       LIST_FOREACH(p, &iph1->ph2tree, ph1bind) {
                 if (p->msgid == msgid && p->ph1 == iph1)
                         return p;
         }
 
 
 --yasuoka
 
 ----- End forwarded message -----
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost