Re: kern/40420

[Takahiro HAYASHI <hash%abox3.so-net.ne.jp@localhost>]

The following reply was made to PR kern/40420; it has been noted by GNATS.

From: Takahiro HAYASHI <hash%abox3.so-net.ne.jp@localhost>
To: paul%whooppee.com@localhost
Cc: hash%abox3.so-net.ne.jp@localhost, tkhr.hash%gmail.com@localhost,
        John Nemeth <jnemeth%netbsd.org@localhost>, 
gnats-bugs%netbsd.org@localhost
Subject: Re: kern/40420
Date: Mon, 22 Feb 2010 12:31:49 +0900

 Hello,
 
 On Sun, 21 Feb 2010 10:24:03 -0800 (PST)
 Paul Goyette <paul%whooppee.com@localhost> wrote:
 
 > > I'm afraid that the name "smsc" will conflict with sys/dev/isa/smsc.c.
 > > That's why I name this driver "smsctemp".
 > > As you say, name of "smsctemp" may not be suitable, i think.
 > > How about "smschwmon"?
 > 
 > Yes, I found that the hard way!
 > 
 > I have taken the liberty of renaming it to smcsmon(4).  I've made a few 
 > other minor changes in the sources (most notably, I replaced the calls 
 > to iic_exec() with calls to iic_smbus_{read,write}_byte()) and I've 
 > written a basic smcsmon(4) man page.  The rest of the code looked pretty 
 > clean to me.  (I personally don't like using the
 > 
 >      { member1 = value1, member2 = value2, ... }
 > 
 > method of initializing the array of sensor descriptors, but it is done 
 > that way in other drivers, so I left it alone.)
 
 I agree with the name smscmon. (I like short name.)
 Thank you for consideration and writing man page.
 
 > I have attached the revised files here - please let me know if this 
 > meets with your approval, and I will commit.
 
 SYNOPSYS in smscmon.4 may be changed to:
 
 -.Cd "smscmon0 at iic? addr 0x2c"
 +.Cd "smscmon0 at iic? addr 0x2d"
 
 because on my D945GCLF board smscmon is seen at iic addr 0x2d.
 No other problems are found, please commit.
 
 -- 
 Takahiro Hayashi <hash%abox3.so-net.ne.jp@localhost>