port-atari/42717: Buffer overrun in clock.c

[henning.petersen%t-online.de@localhost]

>Number:         42717
>Category:       port-atari
>Synopsis:       Buffer overrun  in clock.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-atari-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 02 09:45:00 +0000 2010
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Buffer overrun found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.50 clock.c
--- sys/arch/atari/dev/clock.c  23 Aug 2009 13:46:48 -0000      1.50
+++ sys/arch/atari/dev/clock.c  2 Feb 2010 09:01:15 -0000
@@ -549,7 +549,7 @@
        MC146818_GETTOD(RTC, &clkregs);
        splx(s);
 
-       sprintf(buffer, "%4d%02d%02d%02d%02d.%02d\n",
+       sprintf(buffer, "%4d%02d%02d%02d%02d.%02d",
            clkregs[MC_YEAR] + GEMSTARTOFTIME,
            clkregs[MC_MONTH], clkregs[MC_DOM],
            clkregs[MC_HOUR], clkregs[MC_MIN], clkregs[MC_SEC]);