[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/42210: rename EXDEV & abortop fail
The following reply was made to PR kern/42210; it has been noted by GNATS.
From: David Holland <dholland-bugs%netbsd.org@localhost>
Subject: Re: kern/42210: rename EXDEV & abortop fail
Date: Thu, 22 Oct 2009 00:28:51 +0000
On Wed, Oct 21, 2009 at 07:30:00PM +0000, pooka%iki.fi@localhost wrote:
> In a new and exciting episode of "I thought we fixed the last bug
> from rename last week", plenty of drivers will happily fail VOP_RENAME
> with EXDEV but neglect to call VOP_ABORTOP. Notably, since one of the
> vnodes might be of completely different type, a given driver
> cannot decide to just not call abortop because it "knows" it's
> not required.
Maybe we can abolish ABORTOP? Only onionfs uses it, but the purpose of
the onionfs code in question is clear as mud...
> Is there some layering marvel preventing us from checking for
> EXDEV before calling rename? otherwise, have fun
I have been attempting to figure that one myself, and I don't know of
any valid reason.
David A. Holland
Main Index |
Thread Index |