[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: misc/41684: build.sh syspkgs only works on NetBSD hosts
The following reply was made to PR misc/41684; it has been noted by GNATS.
From: Lloyd Parkes <lloyd%must-have-coffee.gen.nz@localhost>
Subject: Re: misc/41684: build.sh syspkgs only works on NetBSD hosts
Date: Mon, 13 Jul 2009 10:06:29 +1200
On 11/07/2009, at 8:15 AM, Alan Barrett wrote:
> Thanks for the patches, but next time, please use "diff -u" format.
Sorry, that was brain fade. I know I'm supposed to use "diff -u"
> Please try the appended patch, which is closely based on your changes,
> plus removal of the use of pkg_create, and removal of the need for
> "cd -".
That all seems to work fine. I have a personal preference for
replacing 'cd -' with 'cd "$OLDPWD"' because it has less overhead than
invoking a subshell. I couldn't see any obvious performance penalty
when testing it though.
Main Index |
Thread Index |