misc/41684: build.sh syspkgs only works on NetBSD hosts

[lloyd%must-have-coffee.gen.nz@localhost]

>Number:         41684
>Category:       misc
>Synopsis:       build.sh syspkgs only works on NetBSD hosts
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 08 22:30:00 +0000 2009
>Originator:     Lloyd Parkes
>Release:        5.99.12
>Organization:
Must Have Coffee
>Environment:
Darwin inspirit.must-have-coffee.gen.nz 9.7.0 Darwin Kernel Version 9.7.0: Tue 
Mar 31 22:54:29 PDT 2009; root:xnu-1228.12.14~1/RELEASE_PPC Power Macintosh
>Description:
build.sh syspkgs fails with all sorts of strange error messages on OS X, even 
if you have the pkg_* tools available for building packages. It turns out that 
various scripts used to build syspkgs don't work correctly when /bin/sh is bash.

Fixing these few items makes syspkgs buildable on non-NetBSD systems (albeit 
with the hack of using pkgsrc pkg_* tools instead of hosted pkg_* tools).

>How-To-Repeat:
Run build.sh -VMKLINT=no syspkgs on an OS X system after bootstrapping pkgsrc.

You sill then see a complaint about a syntax error on line 991 of regpkg. 
>Fix:
rhox-5.0$ pwd
/vol/build/src-gsoc/distrib/sets
rhox-5.0$ cvs -q diff 
Index: makeplist
===================================================================
RCS file: /vol/src/rsync-src/src/distrib/sets/makeplist,v
retrieving revision 1.19
diff -r1.19 makeplist
126c126
< cd -
---
> cd - > /dev/null
Index: regpkg
===================================================================
RCS file: /vol/src/rsync-src/src/distrib/sets/regpkg,v
retrieving revision 1.16
diff -r1.16 regpkg
642c642
<               host="$(${HOSTNAME})"
---
>               host="$(${HOSTNAME_CMD})"
990c990
<                               # Do nothing (keep the already-registered pkg).
---
>                               : Do nothing - keep the already-registered pkg.
Index: sets.subr
===================================================================
RCS file: /vol/src/rsync-src/src/distrib/sets/sets.subr,v
retrieving revision 1.83
diff -r1.83 sets.subr
86c86
< : ${HOSTNAME:=hostname}
---
> : ${HOSTNAME_CMD:=hostname}   # ${HOSTNAME} is special to bash(1)
rhox-5.0$