bin/41441: savecore doesn't use getbootfile(3) to set a default kernel name

[o.vd.linden%quicknet.nl@localhost]

>Number:         41441
>Category:       bin
>Synopsis:       savecore doesn't use getbootfile(3) to set a default kernel 
>name
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 16 11:40:00 +0000 2009
>Originator:     Onno van der Linden
>Release:        5.99.11
>Organization:
>Environment:
NetBSD sheep 5.99.11 NetBSD 5.99.11 (GENERIC) #0: Wed May  6 15:59:23 MEST 2009 
 onno@sheep:/usr/src/sys/arch/i386/compile/GENERIC i386
>Description:
savecore does not set the default kernel name when the -N option isn't used.
The manual says about -N:  Use system as the kernel instead of the default
                                               (returned by getbootfile(3))


# savecore /var/chrash
May 16 11:54:23 sheep savecore: reboot after panic: panic: trap
May 16 11:54:23 sheep savecore: (null): Bad addres
>How-To-Repeat:
Somehow create a crashdump in the swap partition.
savecore from rc.d failed. savecore by hand fails in the same way
>Fix:
*** savecore.c.orig        Sat May 16 13:34:46 2009
--- savecore.c  Sat May 16 13:34:53 2009
***************
*** 228,233 ****
--- 228,236 ----
        if (!clear)
                dirname = argv[0];
  
+       if (kernel == NULL)
+               kernel = getbootfile();
+ 
        (void)time(&now);
        kmem_setup();