Re: kern/38637: pppoe fails to reconnect sometimes

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/38637; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: Andrew Doran <ad%netbsd.org@localhost>
Cc: Manuel Bouyer <bouyer%antioche.eu.org@localhost>, 
gnats-bugs%NetBSD.org@localhost
Subject: Re: kern/38637: pppoe fails to reconnect sometimes
Date: Wed, 6 May 2009 00:14:40 +0200

 On Tue, May 05, 2009 at 08:52:45PM +0000, Andrew Doran wrote:
 > splhigh/splx on sparc64 should be real functions, or if one believes there
 > is a performance advantage, should be inlines with __insn_barrier in the
 > correct spots. Consider the potential effects elsewhere. I pointed this
 > issue out to Martin or Matthew a couple of years ago and then promptly
 > forgot about it.
 
 You did, and I added the barriers to sparc64/include/psl.h:
 
 ----------------------------
 revision 1.38
 date: 2007/12/11 08:59:57;  author: martin;  state: Exp;  lines: +9 -9
 branches:  1.38.4;  1.38.8;
 Make sure the compiler does not reorder stores accross spl...() calls
 [or, for completeness, calls changing the processor state]. The mutex
 code has small race windows otherwise.
 ----------------------------
 
 Martin