Re: lib/41223: libcurses: curs_set and move do not cause refresh on getch

[Jed Davis <jld%panix.com@localhost>]

The following reply was made to PR lib/41223; it has been noted by GNATS.

From: Jed Davis <jld%panix.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: lib/41223: libcurses: curs_set and move do not cause refresh
        on getch
Date: Tue, 21 Apr 2009 01:22:10 -0400

 I've prepared a patch to make the change I proposed (of removing the
 is_wintouched check), and in minimal testing it appears to work.  See
 http://www.NetBSD.org/~jld/nbcurses-getch-refresh.diff , or below:
 
 Index: lib/libcurses/getch.c
 ===================================================================
 RCS file: /bag/nb/repo/src/lib/libcurses/getch.c,v
 retrieving revision 1.51.8.1
 diff -u -p -r1.51.8.1 getch.c
 --- lib/libcurses/getch.c      18 Feb 2009 01:13:54 -0000      1.51.8.1
 +++ lib/libcurses/getch.c      21 Apr 2009 04:46:59 -0000
 @@ -804,8 +804,7 @@ wgetch(WINDOW *win)
            && __echoit)
                return (ERR);
  
 -      if (is_wintouched(win))
 -              wrefresh(win);
 +      wrefresh(win);
  #ifdef DEBUG
        __CTRACE(__CTRACE_INPUT, "wgetch: __echoit = %d, "
            "__rawmode = %d, __nl = %d, flags = %#.4x, delay = %d\n",
 Index: lib/libcurses/get_wch.c
 ===================================================================
 RCS file: /bag/nb/repo/src/lib/libcurses/get_wch.c,v
 retrieving revision 1.6
 diff -u -p -r1.6 get_wch.c
 --- lib/libcurses/get_wch.c    14 Apr 2008 20:33:59 -0000      1.6
 +++ lib/libcurses/get_wch.c    21 Apr 2009 04:47:08 -0000
 @@ -516,8 +516,7 @@ wget_wch(WINDOW *win, wint_t *ch)
                        && __echoit)
                return (ERR);
  
 -      if (is_wintouched(win))
 -              wrefresh(win);
 +      wrefresh(win);
  #ifdef DEBUG
        __CTRACE(__CTRACE_INPUT, "wget_wch: __echoit = %d, "
            "__rawmode = %d, __nl = %d, flags = %#.4x\n",