kern/41120: recent pullups to netbsd-4 break compilation of sys/dev/ic/rtl8169.c

["Greg A. Woods" <woods%planix.ca@localhost>]

>Number:         41120
>Category:       kern
>Synopsis:       recent pullups to netbsd-4 break compilation of 
>sys/dev/ic/rtl8169.c
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 01 17:20:00 +0000 2009
>Originator:     Greg A. Woods
>Release:        NetBSD 4.0_STABLE
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
        
        
System: NetBSD once 4.0_STABLE NetBSD 4.0_STABLE (GENERIC.MP) #2: Mon Aug 18 
16:24:10 EDT 2008 
woods@once:/rest/build/woods/once/netbsd-4-i386-i386-ppro-obj/rest/work/woods/m-NetBSD-4/sys/arch/i386/compile/GENERIC.MP
 i386
Architecture: i386
Machine: i386
>Description:

        It looks like recent pullups to the netbsd-4 branch seem to have
        been committed without proper testing.

        Compilation breaks in sys/dev/ic/rtl8169.c with the following
        errors:

/rest/work/woods/m-NetBSD-4/sys/dev/ic/rtl8169.c: In function 're_rxeof':
/rest/work/woods/m-NetBSD-4/sys/dev/ic/rtl8169.c:1339: error: 
'RE_RDESC_VLANCTL_IPV4' undeclared (first use in this function)
/rest/work/woods/m-NetBSD-4/sys/dev/ic/rtl8169.c:1339: error: (Each undeclared 
identifier is reported only once
/rest/work/woods/m-NetBSD-4/sys/dev/ic/rtl8169.c:1339: error: for each function 
it appears in.)
/rest/work/woods/m-NetBSD-4/sys/dev/ic/rtl8169.c: In function 're_start':
/rest/work/woods/m-NetBSD-4/sys/dev/ic/rtl8169.c:1653: error: 
'RE_TDESC_VLANCTL_IPCSUM' undeclared (first use in this function)
/rest/work/woods/m-NetBSD-4/sys/dev/ic/rtl8169.c:1657: error: 
'RE_TDESC_VLANCTL_TCPCSUM' undeclared (first use in this function)
/rest/work/woods/m-NetBSD-4/sys/dev/ic/rtl8169.c:1661: error: 
'RE_TDESC_VLANCTL_UDPCSUM' undeclared (first use in this function)


        Probably the following pullup is to blame:

---------- doc/CHANGES-4.1 ----------
sys/dev/ic/rtl8169.c            1.104 (via patch), 1.105 (via patch),
                                1.106 (via patch), 1.108, 1.109 (via patch),
                                1.110, 1.111, 1.112, 1.113
sys/dev/ic/rtl81x9reg.h         1.30, 1.31, 1.32, 1.33, 1.34, 1.35
sys/dev/ic/rtl81x9var.h         1.42, 1.43, 1.44, 1.45
sys/dev/pci/if_re_pci.c         1.35

        Add support for 8168C/8111C/8102E chips
        Fix MAC reset issue (PR kern/41009)
        Add/fix HW checksum support (PR kern/40955)
        [tsutsui, ticket #1297]
--------------------


        BTW, it would be _REALLY_ nice if entries in CHANGES* files had
        the associated commit date(s) included in them!!!!



>How-To-Repeat:

        try to build any of the default kernels which include drivers
        using the noted files.  In particular i386's GENERIC_LAPTOP.

>Fix:

        perhaps something was missed in the pullup, or the patches were
        incomplete?

>Unformatted: