Re: misc/38425 (savecore confused if getbootfile(3) fails)

[Thor Lancelot Simon <tls%rek.tjls.com@localhost>]

The following reply was made to PR misc/38425; it has been noted by GNATS.

From: Thor Lancelot Simon <tls%rek.tjls.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: Andrew Doran <ad%netbsd.org@localhost>, Simon Burge 
<simonb%NetBSD.org@localhost>
Subject: Re: misc/38425 (savecore confused if getbootfile(3) fails)
Date: Fri, 20 Mar 2009 14:34:50 -0400

 Actually, the patch below is better.  No change to libkvm required:
 though the control flow is not tremendously clear, if you pass a NULL
 kernel filename it DTRT.
 
 
 Index: sbin/savecore/savecore.c
 ===================================================================
 RCS file: /cvsroot/src/sbin/savecore/savecore.c,v
 retrieving revision 1.76
 diff -u -r1.76 savecore.c
 --- sbin/savecore/savecore.c   20 Oct 2008 10:34:54 -0000      1.76
 +++ sbin/savecore/savecore.c   20 Mar 2009 18:29:31 -0000
 @@ -228,10 +228,6 @@
        if (!clear)
                dirname = argv[0];
  
 -      if (kernel == NULL) {
 -              kernel = getbootfile();
 -      }
 -
        (void)time(&now);
        kmem_setup();