Re: port-xen/40675: Xen 3.3: guest serial console not functional

[Juergen Hannken-Illjes <hannken%eis.cs.tu-bs.de@localhost>]

The following reply was made to PR port-xen/40675; it has been noted by GNATS.

From: Juergen Hannken-Illjes <hannken%eis.cs.tu-bs.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: Christoph Egger <Christoph_Egger%gmx.de@localhost>
Subject: Re: port-xen/40675: Xen 3.3: guest serial console not functional
Date: Fri, 20 Feb 2009 16:03:09 +0100

 On Fri, Feb 20, 2009 at 02:56:51PM +0100, Christoph Egger wrote:
 > 
 > Nope, that doesn't fix it.
 
 Did you try it out?  I had the problem described in this PR on an
 amd64, running NetBSD-5.0_RC2 with xentools33 (2008Q4) and it
 disappears with my patch.  I printed the terminal attributes after
 openpty() and they were garbage on the first console, valid on the
 second etc.
 
 > With help from uebayasi, I found the issue yesterday
 > and the fix is upstream now:
 > 
 > http://xenbits.xensource.com/staging/xen-3.3-testing.hg?rev/39c14827be55
 > 
 > xenconsoled: make guest console visible on NetBSD dom0
 > 
 > After openpty(), slave_fd must be closed or guest console output
 > goes to the slave while select() in xen console client listens on
 > the master.
 > 
 > --- a/tools/console/daemon/io.c      Fri Feb 20 11:44:27 2009 +0000
 > +++ b/tools/console/daemon/io.c      Fri Feb 20 11:44:58 2009 +0000
 > @@ -420,6 +420,14 @@ static int domain_create_tty(struct doma
 >              goto out;
 >      }
 >  
 > +    /* Close the slave fd or the guest console output disappears,
 > +     * otherwise.
 > +     */
 > +    if (dom->slave_fd != -1) {
 > +            close(dom->slave_fd);
 > +            dom->slave_fd = -1;
 > +    }
 > +
 >      if (dom->use_consolepath) {
 >              success = asprintf(&path, "%s/limit", dom->conspath) !=
 >                      -1;
 > 
 
 This just hides the bug.  We create a pty pair with random attributes,
 close the slave so these attributes disappear and hope the slave will
 be reopened and initialized.
 
 -- 
 Juergen Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig 
(Germany)