toolchain/40402: Unable to build netbsd-4-0 on netbsd-3 - libisc pthread issue

[abs%absd.org@localhost]

>Number:         40402
>Category:       toolchain
>Synopsis:       Unable to build netbsd-4-0 on netbsd-3 - libisc pthread issue
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 15 00:35:00 +0000 2009
>Originator:     abs%absd.org@localhost
>Release:        NetBSD 3.0.1_STABLE
>Organization:
        
>Environment:
        
        
System: NetBSD neteng.city.ac.uk 3.0.1_STABLE NetBSD 3.0.1_STABLE 
(GENERIC_NOIPV6_SMALL) #0: Tue Oct 3 11:13:06 BST 2006 
netcomm%egll.city.ac.uk@localhost:/vol/netbsd/build/netbsd-3-0/sys/arch/i386/compile/GENERIC_NOIPV6
 i386
Architecture: i386
Machine: i386
>Description:
        the dependall phase fails in usr.sbin/bind/libisc because
        the tree appears to be using a combination of isc/pthreads
        and isc/nothreads source and includes - specifically its
        building dist/bind/lib/isc/pthreads/condition.c while
        including dist/bind/lib/isc/nothreads/include/isc/condition.h

        This is *very* strange as usr.sbin/bind/libisc/Makefile
        definitely has NAMED_USE_PTHREADS=no
        which implies
            .PATH.c: ${DIST}/unix ${DIST}/nls ${DIST}/nothreads ${DIST}
        but it picks up condition.c from ${DIST}/pthreads not
        ${DIST}/nothreads

        Renaming ${DIST}/pthreads away causes it to pickup condition.c
        from ${DIST}/nothreads (but it then fails as its picking up 
        some of the include files from ${DIST}/pthreads).

actual error:

        /files/netbsd/netbsd-4-0-RELEASE/tooldir-i386/bin/i386--netbsdelf-gcc 
-O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
-Wno-sign-compare -Wno-traditional  -Werror  -Wno-pointer-sign   
-I/files/netbsd/netbsd-4-0-RELEASE/src/usr.sbin/bind/include  
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind  
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/dns/include 
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/dns/unix/include  
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/include 
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/unix/include  
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/bind9/include  
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isccfg/include  
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isccc/include  
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/lwres/include 
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/lwres/unix/include  
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/dns/s
 ec/dst/include  -DNS_LOCALSTATEDIR=\"/var\"  -DNS_SYSCONFDIR=\"/etc\"  
-DVERSION=\"9.4.2-P2\" -DWANT_IPV6 -DLIBINTERFACE=35  -DLIBREVISION=0 
-DLIBAGE=0 -DOPENSSL 
-I/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/nothreads/include   
-nostdinc -isystem /files/netbsd/netbsd-4-0-RELEASE/destdir/usr/include -c    
/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/pthreads/condition.c -o 
condition.o
        
/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/pthreads/condition.c:36: 
error: expected identifier or '(' before 'void'
        
/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/pthreads/condition.c:36: 
error: expected ')' before '(' token

        For reference in usr.sbin/bind/libisc
         /files/netbsd/netbsd-4-0-RELEASE/tooldir-i386/bin/nbmake-i386 -dA | & 
grep PATH.c
        gives:

   Looking for 
"/files/netbsd/netbsd-4-0-RELEASE/src/usr.sbin/bind/libisc/../../Mak.PATH.c=
ParseReadLine (16): '.PATH.c:   ${DIST}/unix ${DIST}/nls ${DIST}/nothreads 
${DIST}'
ParseDoDependency(.PATH.c:      
/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/unix 
/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/nls 
/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc/nothreads 
/files/netbsd/netbsd-4-0-RELEASE/src/dist/bind/lib/isc)

        Which further confuses me as to why usr.sbin/bind/libisc/Makefile
        is picking up condition.c from dist/bind/lib/isc/pthreads not
        dist/bind/lib/isc/nothreads

>How-To-Repeat:
        ./build.sh using a netbsd-4-0 tree on a netbsd-3 box
>Fix:
        

>Unformatted: