Re: bin/40036: rc.d/network doesn't check IPv6 properly with new ifconfig(8)

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR bin/40036; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: gnats-admin%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: bin/40036: rc.d/network doesn't check IPv6 properly with new 
ifconfig(8)
Date: Fri, 28 Nov 2008 01:27:08 +0900

 > It looks sun2 specific, so I'll check what happens there.
 
 "cc -O1 -fno-loop-optimize" fixes the problem, but
 the attached changes also fixes it.
 
 I'm not sure if it's a gcc optimization bug (on m68000 or m68k+softfloat)
 or a source bug, but is it okay to commit this diff for workaround?
 
 ---
 Index: ifconfig.c
 ===================================================================
 RCS file: /cvsroot/src/sbin/ifconfig/ifconfig.c,v
 retrieving revision 1.213
 diff -u -r1.213 ifconfig.c
 --- ifconfig.c 1 Aug 2008 22:29:13 -0000       1.213
 +++ ifconfig.c 27 Nov 2008 16:19:01 -0000
 @@ -693,14 +693,13 @@
  {
        int i;
        const struct afswtch *afp;
 -      struct kwinst kw = {.k_type = KW_T_INT};
  
        SIMPLEQ_FOREACH(afp, &aflist, af_next) {
 -              kw.k_word = afp->af_name;
 -              kw.k_int = afp->af_af;
                for (i = 0; i < __arraycount(familykw); i++) {
                        if (familykw[i].k_word == NULL) {
 -                              familykw[i] = kw;
 +                              familykw[i].k_type = KW_T_INT;
 +                              familykw[i].k_word = afp->af_name;
 +                              familykw[i].k_int = afp->af_af;
                                break;
                        }
                }
 
 ---