port-amd64/39962: modules/compat missing symbols on amd64

[xtraeme%gmail.com@localhost]

>Number:         39962
>Category:       port-amd64
>Synopsis:       modules/compat missing symbols on amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-amd64-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 20 01:45:00 +0000 2008
>Originator:     Juan RP
>Release:        Latest
>Organization:
>Environment:
NetBSD sasha 5.99.3 NetBSD 5.99.3 (MASTER) #0: Thu Nov 20 01:59:01 CET 2008  
juan@sasha:/home/juan/build/amd64/obj/sys/arch/amd64/compile/MASTER amd64
>Description:
Using a full set of modules on amd64 gives some warnings about missing
symbols in the compat module:

$ modstat
NAME            CLASS   SOURCE  REFS    SIZE    REQUIRES
coredump        misc    filesys 2       3266    -
coretemp        misc    filesys 0       1254    -
exec_elf32      misc    filesys 0       7317    coredump
exec_elf64      misc    filesys 0       7505    coredump
exec_script     misc    filesys 0       1251    -
ext2fs          vfs     filesys 0       39607   ffs
ffs             vfs     boot    1       142307  -
kernfs          vfs     filesys 0       12329   -
ptyfs           vfs     filesys 0       9596    -
$

WARNING: linker error: symbol `esigcode' not found
WARNING: linker error: symbol `compat_16_sys___sigreturn14' not found
WARNING: linker error: symbol `sigcode' not found
WARNING: linker error: symbol `compat_13_sys_sigreturn' not found
WARNING: module error: unable to affix module

The patch I provide doesn't define some old compat versions that are
not really relevant on amd64...

If I remember correctly the amd64 port first appeared in 2.0.
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/src/sys/modules/compat/Makefile,v
retrieving revision 1.1
diff -b -u -p -r1.1 Makefile
--- Makefile    19 Nov 2008 18:36:07 -0000      1.1
+++ Makefile    20 Nov 2008 01:34:09 -0000
@@ -6,11 +6,13 @@
 
 KMOD=  compat
 
+.if ${MACHINE} != "amd64"
 CPPFLAGS+=     -DSYSVSEM -DSYSVSHM -DSYSVMSG -DCOMPAT_43
 CPPFLAGS+=     -DCOMPAT_09 -DCOMPAT_10 -DCOMPAT_11
 CPPFLAGS+=     -DCOMPAT_12 -DCOMPAT_13 -DCOMPAT_14
-CPPFLAGS+=     -DCOMPAT_15 -DCOMPAT_16 -DCOMPAT_20
-CPPFLAGS+=     -DCOMPAT_30 -DCOMPAT_40 -DCOMPAT_50
+CPPFLAGS+=     -DCOMPAT_15 -DCOMPAT_16
+.endif
+CPPFLAGS+=     -DCOMPAT_20 -DCOMPAT_30 -DCOMPAT_40 -DCOMPAT_50
 CPPFLAGS+=     -DCOMPAT_60 -DCOMPAT_70 -DCOMPAT_80
 
 SRCS=  compat_exec.c kern_exit_43.c kern_info_09.c