bin/39506: racoon's pre-shared key file format prohibits names with spaces

[Taylor R Campbell <campbell%mumble.net@localhost>]

>Number:         39506
>Category:       bin
>Synopsis:       racoon's pre-shared key file format prohibits names with spaces
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 09 02:35:00 +0000 2008
>Originator:     Taylor R Campbell <campbell%mumble.net@localhost>
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
System: NetBSD smalltalk.localdomain 4.0_STABLE NetBSD 4.0_STABLE 
(RIAX3DOM0_GATEWAY) #0: Mon Sep 8 20:06:40 UTC 2008 
riastradh%smalltalk.localdomain@localhost:/home/riastradh/netbsd/4/obj/sys/arch/i386/compile/RIAX3DOM0_GATEWAY
 i386
Architecture: i386
Machine: i386
>Description:

        There is no way to associate a key with a name that contains
        spaces in racoon's pre-shared key files.  (This applies to any
        character satisfying isspace(3).)  Keys can be encoded in
        hexadecimal, but names cannot be.

        Furthermore, the sum of the length of the name and the length
        of the key in octets cannot exceed one thousand twenty-two --
        this is one thousand twenty-four minus one for a space octet to
        delimit name from key and one for a null octet at the end.

>How-To-Repeat:

        Stumble across a situation requiring a name containing spaces
        and a key associated with that name; or requiring a name and
        key pair whose length exceeds one thousand twenty-two octets.
        Fail to use racoon.

>Fix:

        Since the format was designed with irksome naivete, there is no
        provision for quoting names or escaping characters such as
        spaces: the format of the file very rigidly terminates each
        name upon any space.  Any change would potentially break
        existing pre-shared key files, which means that it should be
        made as soon as possible to keep people from using the brain-
        damaged format.