NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/39493: Common global symbol defined twice: specfs_lock

>Number:         39493
>Category:       kern
>Synopsis:       Common global symbol defined twice: specfs_lock
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 06 17:50:00 +0000 2008
>Originator:     Juan RP
>Release:        Latest
NetBSD vmware-netbsd 4.99.72 NetBSD 4.99.72 (MASTER) #13: Sat Sep  6 19:20:40 
CEST 2008  juan@vmware-netbsd:/home/juan/build/obj/sys/arch/i386/compile/MASTER 
When linking the kernel with --warn-common, a warning of a common global symbol 
of the same size was found for 'specfs_lock'.

specfs_lock is declared as extern in sys/miscfs/specfs/specdev.h.
specfs_lock is defined as global in sys/miscfs/specfs/specfs_vnops.c.
specfs_lock is defined as global in sys/kern/vfs_subr.c.

Therefore only a definition is needed... I chose to remove the one from

Code inspection.
Index: kern/vfs_subr.c
RCS file: /cvsroot/src/sys/kern/vfs_subr.c,v
retrieving revision 1.355
diff -b -u -p -r1.355 vfs_subr.c
--- kern/vfs_subr.c     31 Jul 2008 05:38:05 -0000      1.355
+++ kern/vfs_subr.c     6 Sep 2008 17:27:28 -0000
@@ -161,7 +161,6 @@ kmutex_t mountlist_lock;
 kmutex_t mntid_lock;
 kmutex_t mntvnode_lock;
 kmutex_t vnode_free_list_lock;
-kmutex_t specfs_lock;
 kmutex_t vfs_list_lock;
 static pool_cache_t vnode_cache;

Home | Main Index | Thread Index | Old Index