[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/39302: can't compile non-WAPBL kernel
On Aug 6, 6:35pm, woods%planix.ca@localhost ("Greg A. Woods; Planix, Inc.")
-- Subject: Re: kern/39302: can't compile non-WAPBL kernel
| The following reply was made to PR kern/39302; it has been noted by GNATS.
| From: "Greg A. Woods; Planix, Inc." <woods%planix.ca@localhost>
| To: gnats-bugs%NetBSD.org@localhost
| Subject: Re: kern/39302: can't compile non-WAPBL kernel
| Date: Wed, 6 Aug 2008 14:33:43 -0400
| On 6-Aug-08, at 2:05 PM, Martin Husemann wrote:
| > The following reply was made to PR kern/39302; it has been noted by
| > GNATS.
| > From: Martin Husemann <martin%duskware.de@localhost>
| > To: gnats-bugs%NetBSD.org@localhost
| > Cc:
| > Subject: Re: kern/39302: can't compile non-WAPBL kernel
| > Date: Wed, 6 Aug 2008 20:03:42 +0200
| > On Wed, Aug 06, 2008 at 05:30:04PM +0000, Juergen Hannken-Illjes
| > wrote:
| >> Does this diff fix the problem:
| > Yes, it does.
| That would suggest then that the current implementation of the macro
| involved violates (at least indirectly) the current kernel coding
| style standards rules.
| Personally I would vote for always enclosing every block in braces,
| even those that only _appear_ to be one statement long, but that might
| be a little bit too invasive for the whole codebase! :-)
| The alternate best fix is perhaps to do exactly as the PR suggested,
| or even just put a pair of empty braces in the "nothing" macro
| definition, assuming this macro can only ever be used as a statement,
| never an expression term.
The macro should be fixed instead.
Main Index |
Thread Index |