[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/38493 CVS commit: src/usr.bin/cdplay
The following reply was made to PR bin/38493; it has been noted by GNATS.
From: Matthias Drochner <drochner%netbsd.org@localhost>
Subject: PR/38493 CVS commit: src/usr.bin/cdplay
Date: Wed, 16 Jul 2008 17:26:25 +0000 (UTC)
Module Name: src
Committed By: drochner
Date: Wed Jul 16 17:26:25 UTC 2008
some improvements to digital play mode:
-use AUMODE_PLAY_ALL, from Sergey Svishchev -- this might cause
stuttering if the write to audio can't keep up, but it avoids pauses
if the audio buffer drains out on stop/resume
-The timeout for the raw SCSI command to read audio data
was too small, causing complete failure for me.
-Since the itimer can't do faster than HZ, a too small buffer doesn't
work. Try to calculate a sensible buffer size.
-While it makes sense to deliver data a bit faster than necessary,
it should be not that much that the blocking in the signal handler
hurts interactive response. Allow for 50ms.
-Comment out a sched_yield() in the signal handler - this doesn't
This is far from being perfect, but it makes digital mode usable for me.
And for Jeremy C. Reed, the author of PR bin/38493.
To generate a diff of this commit:
cvs rdiff -r1.38 -r1.39 src/usr.bin/cdplay/cdplay.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |