[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/38057: ffs makes assuptions about devvp file system
The following reply was made to PR kern/38057; it has been noted by GNATS.
From: Antti Kantee <pooka%iki.fi@localhost>
Subject: Re: kern/38057: ffs makes assuptions about devvp file system
Date: Tue, 19 Feb 2008 12:08:57 +0200
On Tue Feb 19 2008 at 05:20:01 +0000, YAMAMOTO Takashi wrote:
> > >Description:
> > ffs VFS_SYNC/VOP_FSYNC assumes that the device vnode the file system is
> mounted from will be ffs. Otherwise correct routines will not be called,
> especially for softdep. As a simple example, tmpfs relegates VOP_FSYNC to
> spec_fsync, which simply calls vflushbuf() without any regard for
> ffs_full_fsync() hoops and tricks.
> > >How-To-Repeat:
> > >Fix:
> PR/33406 is related.
Indeed it is. I was searching for fsync, sync etc. from gnats, but
33406 is cleverly disguised under softdep ;)
This is an even more obvious problem for some code yet to be checked in,
that it is for softdep. I was thinking if it could be fixed in a general
manner by requiring that VBLK devvp has the properies of the file system
it is used for instead of the file system that the node resides on.
Antti Kantee <pooka%iki.fi@localhost> Of course he runs
"la qualité la plus indispensable du cuisinier est l'exactitude"
Main Index |
Thread Index |