[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: PR/36551: some major improvements for init(8), with accompanying changes to reboot(8) and shutdown(8)
The following reply was made to PR bin/36551; it has been noted by GNATS.
From: David Holland <dholland-bugs%netbsd.org@localhost>
Subject: Re: PR/36551: some major improvements for init(8), with accompanying
changes to reboot(8) and shutdown(8)
Date: Sat, 9 Feb 2008 05:19:18 +0000
I have committed a few bits from this patchset that seemed immediately
If you are serious about getting the rest of this merged, please take
the following steps:
(1) do not submit whitespace changes, *particularly* not whitespace
changes that are not KNF-compliant.
(2) please break the patch up into smaller patches that each do one
thing, and include an explanation of what that thing is and
what problem it's supposed to solve.
As it is, wading through the patch is nearly impossible because it
contains so much noise. Also, some of the changes it appears to
contain seem ill-advised (such as reversing the sense of the -D option
to shutdown) and should be considered independently on their merits.
David A. Holland
Main Index |
Thread Index |