[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/37717: raidclose() no longer called on shutdown...
The following reply was made to PR kern/37717; it has been noted by GNATS.
From: Antti Kantee <pooka%cs.hut.fi@localhost>
Subject: Re: kern/37717: raidclose() no longer called on shutdown...
Date: Tue, 8 Jan 2008 18:37:10 +0200
On Tue Jan 08 2008 at 17:26:14 +0100, Juergen Hannken-Illjes wrote:
> On Tue, Jan 08, 2008 at 03:55:00PM +0000, oster%netbsd.org@localhost wrote:
> > >Number: 37717
> > >Category: kern
> > >Synopsis: raidclose() is no longer called on shutdown
> Since vmlocking2 was merged a root file system containing the root device
> vnode doesn't get closed because its v_usecount is 2 instead of 1 when
> VOP_CLOSE() gets called from ffs_unmount().
> Only need to find the bogus reference...
The extra ref needs to be located if it's being leaked ...
... but more importantly, checking refcounts in VOP_CLOSE is wrong.
A vnode's refcount has nothing to do with open/close. I'd move closing
the b/cdev to spec_inactive.
Antti Kantee <pooka%iki.fi@localhost> Of course he runs
"la qualité la plus indispensable du cuisinier est l'exactitude"
Main Index |
Thread Index |