Subject: Re: port-m68k/37631: m68k libc broken
To: None <gnats-bugs@NetBSD.org>
From: ITOH Yasufumi <itohy@NetBSD.org>
Date: 12/29/2007 02:34:39
> On Fri, Dec 28, 2007 at 03:50:01PM +0000, ITOH Yasufumi wrote:
> > This should be in libc to avoid adding clock cycles to unrelated
> > system calls.
> > See shmat(2) stub.
> I agree, but that is not how it is done right now - and that it didn't
> work for me was just a side effect of me not having COMPAT_AOUT_M68K
Ah, I see. The code to copy return value to a0
didn't exist when I wrote userland ELF support.
> What my change does is just remove the (bogus) dependency on that option.
> All GENERIC kernels already duplicate rval to a0.
> So how about this: I commit the patch (with syscall_fancy added) for now
> and then start collecting a table of missing stubs in the m68k libc.
> Once we have added all missing stubs, we'll make the a0 copy #ifdef COMPAT_50?
That looks fine.