Subject: Re: PR/36394 CVS commit: src/dist/nawk
To: None <firstname.lastname@example.org>
From: Havard Eidnes <he@NetBSD.org>
Date: 10/26/2007 00:17:24
> > Add support for multibyte charsets in the "tolower" and "toupper" =
> > functions.
> Thank you for this.
> > Code contributed by Aleksey Cheusov in PR#36394, and slightly
> > tweaked for closer-to-KNF conventions by me.
> what's this?
KNF stands for Kernel Normal Form, but it's a shorthand for
NetBSD's coding conventions, ref. /usr/share/misc/style. I
didn't follow it completely through, since this is third-party
code. Most touch-ups were just whitespace-related (e.g. no
whitespace after function name or casts).
> > Also slightly improved checks of error returns.
> And especially for this ;-)
> Minor note. According to man page wcrtomb cannot return (size_t) -2.
You're absolutely correct. However, one out of two isn't all bad
either, as "n" can never go negative. :-) I'll remove the
superfluous test shortly.