Subject: Re: PR/36394 CVS commit: src/dist/nawk
To: None <,,>
From: Havard Eidnes <>
List: netbsd-bugs
Date: 10/25/2007 22:20:02
The following reply was made to PR bin/36394; it has been noted by GNATS.

From: Havard Eidnes <>
Subject: Re: PR/36394 CVS commit: src/dist/nawk
Date: Fri, 26 Oct 2007 00:17:24 +0200 (CEST)

 > >  Add support for multibyte charsets in the "tolower" and "toupper" =
 > >  functions.
 > Thank you for this.
 You're welcome.
 > >  Code contributed by Aleksey Cheusov in PR#36394, and slightly
 > >  tweaked for closer-to-KNF conventions by me.
 >                ^^^^^^^^^^^^^
 >                what's this?
 KNF stands for Kernel Normal Form, but it's a shorthand for
 NetBSD's coding conventions, ref. /usr/share/misc/style.  I
 didn't follow it completely through, since this is third-party
 code. Most touch-ups were just whitespace-related (e.g. no
 whitespace after function name or casts).
 > >  Also slightly improved checks of error returns.
 > And especially for this ;-)
 > Minor note. According to man page wcrtomb cannot return (size_t) -2.
 You're absolutely correct.  However, one out of two isn't all bad
 either, as "n" can never go negative. :-)  I'll remove the
 superfluous test shortly.
 - H=E5vard