Subject: Re: kern/36673 (dubious code is sysmon_envsys)
To: None <xtraeme@NetBSD.org, gnats-admin@netbsd.org,>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: netbsd-bugs
Date: 07/23/2007 23:20:03
The following reply was made to PR kern/36673; it has been noted by GNATS.
From: yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi)
To: juan@xtrarom.org
Cc: gnats-bugs@NetBSD.org
Subject: Re: kern/36673 (dubious code is sysmon_envsys)
Date: Tue, 24 Jul 2007 08:16:33 +0900 (JST)
> On Tue, 24 Jul 2007 07:55:24 +0900 (JST)
> yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
>
> > are you asking how it isn't clear?
>
> I wanted to know what parts are wrong or how they can be improved.
the usages of these mutexes are not obvious or documented.
for example,
- i can't understand why sysmon_envsys_createplist acquires
sme_mtx in the loop.
- sysmon_envsys_register seems to assume sysmon_envsys_list is stable
while unlocking sme_list_mtx.
YAMAMOTO Takashi