Subject: Re: kern/36673 (dubious code is sysmon_envsys)
To: None <xtraeme@NetBSD.org, gnats-admin@netbsd.org,>
From: Juan RP <juan@xtrarom.org>
List: netbsd-bugs
Date: 07/23/2007 08:25:02
The following reply was made to PR kern/36673; it has been noted by GNATS.
From: Juan RP <juan@xtrarom.org>
To: yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi)
Cc: gnats-bugs@NetBSD.org
Subject: Re: kern/36673 (dubious code is sysmon_envsys)
Date: Mon, 23 Jul 2007 10:23:30 +0200
On Mon, 23 Jul 2007 10:59:46 +0900 (JST)
yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
> please re-open.
> can you re-read the PR and code by yourself before closing it?
> thanks.
>
> > - what global mutexes like sme_mtx protect is not clear.
What's the problem with this?
> > - sysmon_envsys_createplist seems to ignore most errors
> > unless it was for the last sensor in sme_sensor_data[].
> > i don't understand why the last one is special.
Have you seen the changes I made yesterday? how is the current
code looking at the last error of sme_sensor_data now?
--
Juan Romero Pardines - The NetBSD Project
http://plog.xtrarom.org - NetBSD/pkgsrc news in Spanish