Subject: Re: kern/36673 (dubious code is sysmon_envsys)
To: None <xtraeme@NetBSD.org, gnats-admin@netbsd.org,>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: netbsd-bugs
Date: 07/23/2007 02:00:12
The following reply was made to PR kern/36673; it has been noted by GNATS.
From: yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi)
To: gnats-bugs@NetBSD.org
Cc: xtraeme@NetBSD.org, netbsd-bugs@netbsd.org,
gnats-admin@netbsd.org, xtraeme@netbsd.org
Subject: Re: kern/36673 (dubious code is sysmon_envsys)
Date: Mon, 23 Jul 2007 10:59:46 +0900 (JST)
> Synopsis: dubious code is sysmon_envsys
>
> State-Changed-From-To: feedback->closed
> State-Changed-By: xtraeme@netbsd.org
> State-Changed-When: Sun, 22 Jul 2007 18:18:27 +0000
> State-Changed-Why:
> I just fixed your last point, thanks for your PR.
please re-open.
can you re-read the PR and code by yourself before closing it? thanks.
> - what global mutexes like sme_mtx protect is not clear.
> - sysmon_envsys_createplist seems to ignore most errors
> unless it was for the last sensor in sme_sensor_data[].
> i don't understand why the last one is special.
YAMAMOTO Takashi