Subject: Re: kern/36673: dubious code in sysmon_envsys
To: None <,,>
From: Juan RP <>
List: netbsd-bugs
Date: 07/21/2007 17:40:02
The following reply was made to PR kern/36673; it has been noted by GNATS.

From: Juan RP <>
Cc: (YAMAMOTO Takashi)
Subject: Re: kern/36673: dubious code in sysmon_envsys
Date: Sat, 21 Jul 2007 19:39:23 +0200

 On Sat, 21 Jul 2007 17:35:01 +0000 (UTC) (YAMAMOTO Takashi) wrote:
 >  then, sysmonioctl_envsys seems broken.
 I fixed it, please check latest code.
 >  it depends.
 >  what i want to know is if it's safe to drop the lock here,
 >  rather than a reason why you want to drop it...
 Do you think is it safe? well, I don't know. Do you have any idea
 how to change it to be safe?
 >  what happens when you call sme_update_dictionary again?
 >  you decrease sme_nsensors again erroneously, don't you?
 >  i guess it's clearer to always use same indexes for sme_sensor_data
 > and prop_array.  ie. use prop_array_set instead of prop_array_add.
 Oh right... I didn't think about this case. I'll fix now, thank you.
 Juan Romero Pardines 	- The NetBSD Project 	- NetBSD/pkgsrc news in Spanish