Subject: Re: bin/36458 ("envstat -r" doesn't show what "envstat" shows)
To: None <,,>
From: Greg A. Woods <>
List: netbsd-bugs
Date: 07/03/2007 18:00:13
The following reply was made to PR bin/36458; it has been noted by GNATS.

From: "Greg A. Woods" <>
Cc: <>, <>
Subject: Re: bin/36458 ("envstat -r" doesn't show what "envstat" shows)
Date: Tue, 03 Jul 2007 13:58:59 -0400

 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 At Tue,  3 Jul 2007 09:03:00 +0000 (UTC), wrote:
 Subject: Re: bin/36458 ("envstat -r" doesn't show what "envstat" shows)
 > Synopsis: "envstat -r" doesn't show what "envstat" shows
 > State-Changed-From-To: open->closed
 > State-Changed-By:
 > State-Changed-When: Tue, 03 Jul 2007 09:02:58 +0000
 > State-Changed-Why:
 > This patch is not correct and I'll explain you why:
 > Indicator sensors are only shown when they are enabled (when
 > the ENVSYS_FVALID and ENVSYS_FCURVALID are set) and if=20
 > it has a value.
 > Your patch is showing these sensors even when they are disabled.
 > This is what the code intended to do, it's intentional.
 Well, I don't have access to much of a variety of systems with supported
 sensors yet, but if what you're saying is true then there's a huge pile
 of bogus or broken code somewhere else.
 On the systems I have access to my changes make the row mode output show
 _exactly_ the same stuff as the column mode output.
 I don't really care which is wrong, but both modes really MUST show
 exactly the same set of sensors!  (and of course that set should be all
 the available sensors!)
 All I did was make the row-mode code work the same way as the column
 mode code, since on at least one of my systems my fix allows sensors
 which the motherboard manual state really should be there to appear just
 as they appear in the column mode, so either something's reading the
 valid flags wrong, or maybe they're not set right in the firmware, but
 either way the column mode shows them as expected while the row mode did
 not show them before my fix.
 Note there's also a strong argument to be made for showing sensors even
 when their values are claimed to be invalid (but of course giving a
 recognizable indication that their value is in fact invalid).  An
 invalid value is really nothing more than a value that is out of range
 and it's just as important for monitoring software to see invalid sensor
 values as it is for it to see valid values that are out of range.
 If a sensor itself is invalid (i.e. it isn't even supported in any way
 by the hardware), then I can see good reason for not reporting the
 sensor.  Obviously there can be an infinite number of invalid sensors
 and you can't report them all.
 > Starting with envsys2 (-current since 1st July), row mode is=20
 > the default.
 This is a VERY good thing!
 (which makes it even more important that the row mode show exactly the
 same set of all sensors that the column mode once did!)
 						Greg A. Woods
 H:+1 416 218-0098 W:+1 416 489-5852 x122 VE3TCP RoboHack <>
 Planix, Inc. <>       Secrets of the Weird <>
 Content-Type: application/pgp-signature
 Content-Transfer-Encoding: 7bit
 Version: PGPfreeware 5.0i for non-commercial use
 MessageID: AaC9AFcUgx1jrcrl+KknsMZgi8qXgHCW