Subject: kern/36037: [PATCH] wdc(4) breaks build of DEBUG kernel
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <lkundrak@redhat.com>
List: netbsd-bugs
Date: 03/19/2007 11:20:01
>Number:         36037
>Category:       kern
>Synopsis:       [PATCH] wdc(4) breaks build of DEBUG kernel
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 19 11:20:01 +0000 2007
>Originator:     Lubomir Kundrak
>Release:        
>Organization:
>Environment:
>Description:
DPRINTF() statement in wdc_reset_drive() still contains a reference to atac structure, which was removed.
>How-To-Repeat:
Try to build -current DEBUG kernel with wdc(4) driver.
>Fix:
Index: sys/dev/ic/wdc.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/wdc.c,v
retrieving revision 1.247
diff -p -u -r1.247 wdc.c
--- sys/dev/ic/wdc.c    17 Mar 2007 06:41:35 -0000      1.247
+++ sys/dev/ic/wdc.c    19 Mar 2007 11:13:20 -0000
@@ -906,7 +906,7 @@ wdc_reset_drive(struct ata_drive_datas *
        struct ata_channel *chp = drvp->chnl_softc;

        ATADEBUG_PRINT(("wdc_reset_drive %s:%d for drive %d\n",
-           atac->atac_dev.dv_xname, chp->ch_channel, drvp->drive),
+           drvp->drv_softc->dv_xname, chp->ch_channel, drvp->drive),
            DEBUG_FUNCS);

        ata_reset_channel(chp, flags);
$