Subject: Re: kern/35728: repeated kernel panics: free: duplicated free (NFS-related)
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Antti Kantee <pooka@cs.hut.fi>
List: netbsd-bugs
Date: 02/20/2007 15:00:04
The following reply was made to PR kern/35728; it has been noted by GNATS.

From: Antti Kantee <pooka@cs.hut.fi>
To: Arto Selonen <arto+dated+1171983012.7260a288b3420c78@selonen.org>
Cc: gnats-bugs@NetBSD.org, netbsd-bugs@netbsd.org
Subject: Re: kern/35728: repeated kernel panics: free: duplicated free (NFS-related)
Date: Tue, 20 Feb 2007 16:55:09 +0200

 On Tue Feb 20 2007 at 16:49:07 +0200, Arto Selonen wrote:
 > This is from a crash dump with the unsuccessfully patched kernel:
 >
 > [snip]
 >
 > (gdb) list *0xc01959eb
 > 0xc01959eb is in nfsrv_readdir (/cvs/src/sys/nfs/nfs_serv.c:2658).
 > 2653            VOP_UNLOCK(vp, 0);
 > 2654            if (error) {
 > 2655                    vrele(vp);
 > 2656                    free((caddr_t)rbuf, M_TEMP);
 > 2657                    if (cookies)
 > 2658                            free((caddr_t)cookies, M_TEMP);
 > 2659                    nfsm_reply(NFSX_POSTOPATTR(v3));
 > 2660                    nfsm_srvpostop_attr(getret, &at);
 > 2661                    return (0);
 > 2662            }
 
 Ok, that at least confirms that the second patch is trying to fix the
 problem on the correct line.
 
 > Is your second patch in addition to the first one or instead of it:
 
 "both" ;)
 
 i.e. doesn't matter.
 
 -- 
 Antti Kantee <pooka@iki.fi>                     Of course he runs NetBSD
 http://www.iki.fi/pooka/                          http://www.NetBSD.org/
     "la qualité la plus indispensable du cuisinier est l'exactitude"