Subject: kern/34250: Wrong comment in rnd.c
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <jacereda@users.sourceforge.net>
List: netbsd-bugs
Date: 08/21/2006 20:10:00
>Number:         34250
>Category:       kern
>Synopsis:       Wrong comment in rnd.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Aug 21 20:10:00 +0000 2006
>Originator:     Jorge Acereda Macia
>Release:        
>Organization:
>Environment:
>Description:
From rnd.c

/*
 * Add a value to the entropy pool.  If rs is NULL no entropy estimation
 * will be performed, otherwise it should point to the source-specific
 * source structure.
 */
void
rnd_add_uint32(rndsource_element_t *rs, u_int32_t val)
{
	rndsource_t *rst;
	rnd_sample_t *state;
	u_int32_t ts;
	int s;

	rst = &rs->data;

	if (rst->flags & RND_FLAG_NO_COLLECT)
		return;
...

So, either rs can't be NULL or the comment is wrong.

>How-To-Repeat:

>Fix: